]> dgit.raspbian.org Git - gnome-shell.git/commit
keyboard: Stop offsetting the focus rectangle
authorJonas Dreßler <verdre@v0yd.nl>
Sat, 27 Feb 2021 10:37:24 +0000 (11:37 +0100)
committerMarge Bot <marge-bot@gnome.org>
Fri, 12 Mar 2021 15:56:12 +0000 (15:56 +0000)
commitb160e44dab1260136d244e29eeb76508fa20d2d3
tree918a9a3f81b37e989b54dc7f0829533144c24ca6
parent746230f8b68fee9efb314f0acade5f65c626c2b3
keyboard: Stop offsetting the focus rectangle

The focus rectangle of the OSK currently gets stored with an offset that
removes the global coordinates and makes it window-local coordinates.
This offsetting has been applied since the introduction of the
FocusTracker with commit fc5ab4470445992b1ad4338290deb24e6b1c5ce2 and it
seems there's no real reason for it.

By removing this, we also emit position-changed when the window has
moved but the window-local coordinates stayed the same. We really want
to emit position-changed in that case because it might affect whether
the window needs to be shifted up.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1728>
js/ui/keyboard.js